Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MLD switch for cyanobacteria - making euphotic zone N2 uptake remaining default #395

Closed
jmaerz opened this issue Sep 10, 2024 · 2 comments · Fixed by #396
Closed
Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base

Comments

@jmaerz
Copy link
Collaborator

jmaerz commented Sep 10, 2024

Hi @TomasTorsvik,
I was briefly discussing with @JorgSchwinger about the next steps to be taken towards the iHAMOCC version for NorESM2.5 (as summarized in #340). We introduced those switches for cyanobacteria N2 uptake taking place in either the MLD or the euphotic zone only to enable better technical comparability between the isopycnic and the hybrid coordinates in BLOM. @TomasTorsvik : are they still needed or is this an outdated task and the switch can be removed in favor of cyanobacteria uptake only in the euphotic zone?

@jmaerz jmaerz added the iHAMOCC Issue mainly concerns the iHAMOCC code base label Sep 10, 2024
@jmaerz jmaerz added this to the NorESM2.5 - BLOM/iHAMOCC milestone Sep 10, 2024
@TomasTorsvik
Copy link
Contributor

@jmaerz - are you referring to the leuphotic_cya switch?

          do k=1,merge(kwrbioz(i,j),kmle(i,j),leuphotic_cya) ! if leuphotic_cya=.true., do bluefix only in euphotic zone

I think we can simplify this to do k=1,kwrbioz(i,j)

@jmaerz
Copy link
Collaborator Author

jmaerz commented Sep 10, 2024

Yes, that's what we will do eventually - I was just remembering that you had once the incentive to look into the hybrid versus isopycnic coordinates which demanded to have the switch build-in. From your answer, I grasp that we can remove it now again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants