-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mocha from hardhat-core #2455
Comments
We need to let plugin authors know that they must explicitly depend on |
This issue was marked as stale because it didn't have any activity in the last 30 days. If you think it's still relevant, please leave a comment indicating so. Otherwise, it will be closed in 7 days. |
Relevant. |
This issue was marked as stale because it didn't have any activity in the last 30 days. If you think it's still relevant, please leave a comment indicating so. Otherwise, it will be closed in 7 days. |
This issue was closed because it has been stalled for 7 days with no activity. |
it would be a really nice feature to have. I would like to integrate with my already in use |
We want to remove Mocha from hardhat-core. Users should be able to just install and require a plugin (e.g.,
@nomiclabs/hardhat-mocha
) to have the same functionality that they have now.Since this is a breaking change, we should do it in two phases.
Phase 1: create plugin and add warning
First we should create and publish that plugin, and change the default
test
task so that it prints a warning after finishing, saying something like: "The default test task is deprecated, please install and use <plugin-name>"The plugin would override the
test
task with the same implementation we have now, and without callingrunSuper
. That way the behavior wouldn't change, but the warning wouldn't be shown.Phase 2: remove default implementation and throw an error in the
test
taskAfter some time (~2 months) we should remove the dependency on mocha and change the default task to just throw an error indicating users to install
hardhat-mocha
.Other considerations
I'm not sure what this means for plugins. For example, I think this would break
hardhat-gas-reporter
if the plugin is required before thehardhat-mocha
plugin.The text was updated successfully, but these errors were encountered: