Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardhat_allowUnlimitedContractSize RPC method #1718

Open
alcuadrado opened this issue Jul 22, 2021 · 2 comments
Open

Add hardhat_allowUnlimitedContractSize RPC method #1718

alcuadrado opened this issue Jul 22, 2021 · 2 comments
Labels
blocked-reason:needs-edr status:blocked Blocked by other issues or external reasons type:feature Feature request

Comments

@alcuadrado
Copy link
Member

The allowUnlimitedContractSize setting is now project wide. This means that if one of your contracts (e.g. a mock) is above the contract size limit, you have to disable for all your tests. This can hide the fact that some other contract is above the size limit, when it shouldn't.

Adding a hardhat_allowUnlimitedContractSize RPC method would give more fine-grained control over that, and let you avoid that situation.

This should be fairly straightforward to implement. We have to instantiate a new VM with the new config value, and replace the one that's inside the HardhatNode class.

@fvictorio
Copy link
Member

Should this be called hardhat_setAllowUnlimitedContractSize? (I don't know which one I prefer, I'm just asking it out loud)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

This issue was marked as stale because it didn't have any activity in the last 30 days. If you think it's still relevant, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 8, 2022
@fvictorio fvictorio added not-stale and removed Stale labels Aug 8, 2022
@fvictorio fvictorio added status:blocked Blocked by other issues or external reasons blocked-reason:needs-edr and removed package:hardhat-core labels Dec 22, 2022
@fvictorio fvictorio moved this to Blocked in Hardhat Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-reason:needs-edr status:blocked Blocked by other issues or external reasons type:feature Feature request
Projects
Status: Blocked
Development

No branches or pull requests

2 participants