Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with TheOneSmeagle (Or TheOneProbe build from source) #29

Open
strubium opened this issue Oct 10, 2024 · 7 comments
Open

Crash with TheOneSmeagle (Or TheOneProbe build from source) #29

strubium opened this issue Oct 10, 2024 · 7 comments

Comments

@strubium
Copy link

Largely just reporting this so you guys know, I will be trying to fix it

Will crash when launched, because the last thing McJty did before dropping 1.12.2 was renaming
Config to ConfigSetup. This change was never built and released, which is why you can use the build on CurseForge without issues.

More info:
strubium/TheOneSmeagle#2

@IntegerLimit
Copy link
Member

Ah, should be a simple fix, if we were to switch to TheOneSmeagle. What is TheOneSmeagle?

@strubium
Copy link
Author

Ah, should be a simple fix, if we were to switch to TheOneSmeagle. What is TheOneSmeagle?

TheOneSmeagle is my UEL fork of The One Probe with language translation support, some new providers for vanilla stuff, and slightly better texture pack support.

My full changelog is in my readme if you want to look at it here

@IntegerLimit
Copy link
Member

I'm curious at the compat of this with other mods, since I imagine lots of mods use TOP's Config class. Will do some testing, and the features look great, so if all goes well, this should be integrated into labs and nomi.

@IntegerLimit
Copy link
Member

We might wait for the mod to mature slightly, but since its not a GT addon (where we have to worry about compat with newer GT versions), it should not be too big of a problem.

@strubium
Copy link
Author

I'm curious at the compat of this with other mods, since I imagine lots of mods use TOP's Config class. Will do some testing, and the features look great, so if all goes well, this should be integrated into labs and nomi.

This is actually the first incompatibility I've found (It even works with Non-Immersive HUD), probably because it mixins into it to fix fluid localization (Shameless plug: I've fixed that)

We might wait for the mod to mature slightly, but since its not a GT addon (where we have to worry about compat with newer GT versions), it should not be too big of a problem.

I'm largely taking feature requests in the Cleanroom discord, so let me know if there is something you would like to see added.

@ChromaPIE
Copy link

Any update to this?

@IntegerLimit
Copy link
Member

IntegerLimit commented Oct 15, 2024

This would be after 1.7.3, in the 1.8 line of releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants