Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget UserId lookup code change request #39

Open
scottcher opened this issue May 3, 2013 · 0 comments
Open

Widget UserId lookup code change request #39

scottcher opened this issue May 3, 2013 · 0 comments

Comments

@scottcher
Copy link

We recently converted our internal Question2Answer site to use a custom SSO implementation and as part of that also implemented a Q2A plugin to switch from displaying the user's handle to displaying the user's name from their profile (if its filled in). This change affects the question list, question page and the user list.

As soon as the user's handle display was replaced for user that had entered a name in their profile, the badge widgets stopped displaying. This is because of how the badges plugin is looking for the user handle on those pages.

We modified your code to look at the URL that's associated with the user display, which still references the user-handle. I thought I would let you know - we think it may be a better way for your badges widgets to work and can provide the code changes we made if you would like to take a look at them.

It would be a tad crass for me to ask you to update your plugin to suit our needs, so I won't do that - I just wanted to provide you with the information to see if you think our code changes might be an improvement.

Let me know if you are interested in seeing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant