Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability Roundup 28 #30959

Closed
63 of 74 tasks
ckauhaus opened this issue Oct 30, 2017 · 29 comments
Closed
63 of 74 tasks

Vulnerability Roundup 28 #30959

ckauhaus opened this issue Oct 30, 2017 · 29 comments
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one

Comments

@ckauhaus
Copy link
Contributor

ckauhaus commented Oct 30, 2017

Auto-generated from vulnix $( nix-instantiate -I nixpkgs=. '<nixpkgs/nixos/tests/login.nix>' ) on current master.

audiofile-0.3.6 (search, files)

cyrus-sasl-2.1.26 (search, files)

freetype-2.7.1 (search, files)

jquery-ui-1.11.4 (search, files)

libarchive-3.3.2 (search, files)

libjpeg-turbo-1.5.2 (search, files)

libsndfile-1.0.28 (search, files)

libtasn1-4.12 (search, files)

libtiff-4.0.8 (search, files)

libvorbis-1.3.5 (search, files)

libxslt-1.1.29 (search, files)

openjpeg-2.1.2 (search, files)

openldap-2.4.45 (search, files)

pcre-8.40 (search, files)

perl-5.24.2 (search, files)

sqlite-3.20.0 (search, files)

owncloud-7.0.5 (search, files)

jython-2.7.0 (search, files)

zabbix-2.0.11 (search, files)

@grahamc
Copy link
Member

grahamc commented Oct 30, 2017

🚨 ⚡️ 👍 🔥 🚒 🎆 🙌 📯 😄 😂 😹 :partyparrot:

@grahamc
Copy link
Member

grahamc commented Oct 30, 2017

cc: @LnL7 @7c6f434c @fpletz @globin @NeQuissimus @wizeman @FRidh @vcunat @peterhoeg @ndowens @dezgeg @nh2.

Note: The list of people CC'd on this issue participated in the last
roundup. If you participate on this roundup, I'll cc you on the next
one. If you don't participate in the next one, you won't be CC'd on
the one after that. If you would like to be CC'd on the next roundup,
add a comment to the most recent vulnerability roundup.

Permanent CC's: @joepie91, @phanimahesh, @the-kenny, @7c6f434c, @k0001, @peterhoeg
@NixOS/security-notifications

If you would like to be CC'd on all roundups, PM me.

@ckauhaus
Copy link
Contributor Author

This list needs manual cleanup since vulnix does not honour CVE patches already present. Working on this.

@disassembler
Copy link
Member

I'm looking at freetype.

@disassembler
Copy link
Member

freetype-2.7.1 (search, files) (CVE-2017-8105) is already patched.

@dezgeg
Copy link
Contributor

dezgeg commented Oct 30, 2017

Sqlite needs merging #30927 AFAICT.

@disassembler
Copy link
Member

#21161 Should resolved jquery-ui CVE.

@disassembler
Copy link
Member

libxslt is already patched in master and 17.09.

@disassembler
Copy link
Member

I'll take libjpeg-turbo

@fpletz
Copy link
Member

fpletz commented Oct 30, 2017

The openldap CVE-2017-14159 is a minor issue with PID file creation. It is only really applicable if initscripts are used, so NixOS isn't even vulnerable since our openldap service neither uses nor creates a PID file. Ticked off.

@NeQuissimus
Copy link
Member

All the audiofile stuff seems to be mpruett/audiofile#42

@pbogdan
Copy link
Member

pbogdan commented Oct 30, 2017

sqlite - staging is already on 3.20.1 but that suffers from CVE-2017-15286, a PR is opened to update to 3.21.0 #30927

@pbogdan
Copy link
Member

pbogdan commented Oct 30, 2017

libtiff - we have patches for:

CVE-2017-9937 - appears to be a incorrectly assigned, the bug is in jbigkit package - http://bugzilla.maptools.org/show_bug.cgi?id=2707

@7c6f434c
Copy link
Member

7c6f434c commented Oct 30, 2017

libtasn1: source reports fixing CVE-2017-9310 with an upstream patch; in reality it seems to be a patch for CVE-2017-10790. It seems that https://nvd.nist.gov/vuln/detail/CVE-2017-9310 is about Qemu anyway… It seems that Debian imported the same patch http://git.savannah.nongnu.org/cgit/libtasn1.git/patch/?id=d8d805e1f2e6799bb2dff4871a8598dc83088a39 as a fix for CVE-2017-10790 in
https://anonscm.debian.org/cgit/pkg-gnutls/libtasn1.git/commit/?id=75d2ac4bcc8c92515d1bbda33103c5f78d353a6e

Could anyone recheck that I am not missing something?

Edited to add: and, of course, renaming the patch will be a gtk-rebuild…

@adisbladis
Copy link
Member

adisbladis commented Oct 30, 2017

CVE-2017-14166 and CVE-2017-14502 (libarchive) fixed in #30990.

The other two (CVE-2017-14503 and CVE-2017-14166) has no upstream patches yet.

@peterhoeg
Copy link
Member

The following openjpeg CVEs are already fixed in master and 17.09 ref 428927f :

So I'm marking those.

@flokli
Copy link
Contributor

flokli commented Nov 1, 2017

Actually, CVE-2017-10790 got fixed in 1fb803c (although pretending to have fixed CVE-2017-9310), so this can be checked too.

I added a commit in #31082 fixing the CVE number.

@flokli
Copy link
Contributor

flokli commented Nov 1, 2017

jython fix comes with #31090.

@vcunat
Copy link
Member

vcunat commented Nov 1, 2017

I've got bad news for nixos-unstable* channels.

-small jobset has succeeded hours ago, but apparently the channel script is stuck. The big jobset is blocked by one test that seems impossible to start, even if I cancel and restart it. /cc @edolstra

EDIT: nixos-unstable updated now and should be OK, whereas -small keeps stuck, paradoxically.

@vcunat
Copy link
Member

vcunat commented Nov 1, 2017

I picked this round of mass rebuilds to 17.09. In case of e.g. sqlite it may have been more suitable to find and apply only specific patches instead of the upgrades; certainly feel free to do so (I don't have that much time to spare).

@vcunat
Copy link
Member

vcunat commented Nov 1, 2017

And speaking of time, I ignored 17.03, at least for now. IIRC we used to leave only a month's overlay, so we might just drop picking to 17.03 except for really critical problems. I really have no idea how fast NixOS users migrate, but one month probably isn't too much. I believe we should at least explicitly announce such plans in advance, saying e.g. that 17.09 shall be maintained (at least) until the end of May 2018.

@fpletz
Copy link
Member

fpletz commented Nov 1, 2017

I was also just about to also push those cherry-picks after having tested a few builds. Thanks! I'm more liberal concerning minor package bumps if they don't break any of our packages.

Regarding the security support: I agree but let's wait until we have the security team and 'on call' figured out. I'll also try to fix the most important ones for 17.03.

@fpletz fpletz added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 1, 2017
@fpletz fpletz added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 1, 2017
@adisbladis
Copy link
Member

All of theowcloud vulnerabilities are fixed after version 8.1.2.

@matejc Is there any reason to keep so many old versions around?

@vcunat
Copy link
Member

vcunat commented Nov 5, 2017

We have a libc problem: https://nvd.nist.gov/vuln/detail/CVE-2017-15670

Plan:

  • pick just the patch for 17.09, and verify there aren't more missed security patches; EDIT: 6566d0a
  • on staging update to 2.26+stable directly, and get to nixos-unstable* soon

@grahamc
Copy link
Member

grahamc commented Nov 5, 2017 via email

@vcunat
Copy link
Member

vcunat commented Nov 7, 2017

glibc: on 17.09 it's in channels (probably), and we have it on master as well, with some caveats: 6ffafc7.

@fpletz
Copy link
Member

fpletz commented Nov 19, 2017

Patched the audiofile issues.

fpletz added a commit that referenced this issue Nov 19, 2017
Fixes the patches names for security tools to parse CVEs.

Adds patch to fix CVE-2017-14634.

cc #30959
fpletz added a commit that referenced this issue Nov 19, 2017
fpletz added a commit that referenced this issue Nov 19, 2017
Fixes the patches names for security tools to parse CVEs.

Adds patch to fix CVE-2017-14634.

cc #30959

(cherry picked from commit 58218d4)
fpletz added a commit that referenced this issue Nov 19, 2017
fpletz added a commit that referenced this issue Nov 19, 2017
@fpletz
Copy link
Member

fpletz commented Nov 19, 2017

Fixed all remaining fixable CVEs and added comments to the remaining issues. Most can't be fixed because there is no upstream fix yet. I think we can close this issue now and do another roundup soon.

@fpletz fpletz closed this as completed Nov 19, 2017
@fpletz fpletz removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 19, 2017
@ckauhaus ckauhaus mentioned this issue Nov 27, 2017
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Development

No branches or pull requests