Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC-10 Compiler Warnings (Removing "-fcommon") #34

Open
Nitepone opened this issue Jan 23, 2021 · 1 comment
Open

GCC-10 Compiler Warnings (Removing "-fcommon") #34

Nitepone opened this issue Jan 23, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Nitepone
Copy link
Owner

Nitepone commented Jan 23, 2021 •
edited
Loading

Currently, log.h is creating global variables that are defined in multiple objects. This causes build failures in gcc-10 during linking time if the linked objects define the same global variables.

See https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common for more info on this change.
@Nitepone Nitepone added the bug Something isn't working label Jan 23, 2021
@Nitepone Nitepone mentioned this issue Jan 23, 2021
Merged
@Nitepone
Copy link
Owner Author

This is temporarily resolved by #35 , but we should make changes to our logging system to remove the need for the -fcommon compile flag.

@Nitepone Nitepone changed the title fcommon GCC-10 Compiler Warnings (-fcommon) Jan 29, 2021
@Nitepone Nitepone changed the title GCC-10 Compiler Warnings (-fcommon) GCC-10 Compiler Warnings (Removing "-fcommon") Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nitepone