New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dom memory Leak #57

Open

OnurGumus opened this issue Jul 7, 2023 · 1 comment

OnurGumus commented Jul 7, 2023

I see the mappings are attached to dom tree, but not cleaned on dispose here:

https://github.com/Nhowka/Elmish.Bridge/blob/0134e2ad4566f5c254c5e80add39edbbef17371c/src/Client/Library.fs#L28C11-L28C11

Isn't this leaking, when I don't need elmish bridge?

Author

OnurGumus commented Jul 7, 2023

Ok these are not leaking, but the map retains those callbacks which eventually leaks. Dispose also should remove relevant keys from the map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment