This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Fix for issue 1150 #1153
Closed
Fix for issue 1150 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue #1150
mikegrima
suggested changes
Nov 24, 2018
There was a problem hiding this comment.
query = query.join((Account, Account.id == Item.account_id)) <-- this is still needed, but only once.
Probably need to add a boolean to indicate that this is needed, and then at the end of all the if statements, add in another that adds it in if the check is True.
|
Did the new fix as requested. Hope that it is in a way that you are able approve. Sorry for any bad coding design. |
|
@macedogm It looks the same. |
|
Sorry. Will open a new PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #1150