This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Permissive task capability #3866
Open
ivakoleva
wants to merge
7
commits into
Netflix:main
Choose a base branch
from
ivakoleva:permissive-task-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 27, 2023
-
Why: We need idempotent forked tasks, meaning all tasks get executed, but any failures are still detected upon join. Feature request Netflix#3861 What: Introduced the concept of Permissive tasks. A Permissive task is similar to a Simple task. The difference is, it permits the other tasks to continue - in case a Permissive task failed. Result is: 1. Forked Permissive tasks will let each other be evaluated, until all the forked tasks had terminated. Only then, the join task should fail. In case of Permissive optional tasks, the join will not fail. 2. Permissive sequential tasks will let subsequent tasks continue. While at the end, the workflow will fail in case a permissive task had failed. The workflow would not fail in case of Permissive optional task failure. Testing done: PermissiveTaskMapperTest added, TestDeciderOutcomes.testPermissive() added, WorkflowAndTaskConfigurationSpec "Test simple workflow which has a permissive task" and "Test simple workflow which has a permissive optional task added" that cover retry, ForkJoinSpec "Test a simple workflow with fork join permissive failure flow" added. In addition, performed e2e tests locally running a Conductor instance. Did build a docker image with the code changes made, started it locally, and started a SampleWorker to poll 3 tasks in parallel. Verified e2e scenarios of task_def_permissive, task_def_permissive_optional, task_def_simple.json, task_def_simple_optional.json, each joining on 6 forked tasks, then running simple task 7 after join.
Configuration menu - View commit details
-
Copy full SHA for 6883859 - Browse repository at this point
Copy the full SHA 6883859View commit details -
Configuration menu - View commit details
-
Copy full SHA for d51ab62 - Browse repository at this point
Copy the full SHA d51ab62View commit details
Commits on Nov 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for af53c50 - Browse repository at this point
Copy the full SHA af53c50View commit details
Commits on Dec 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 14d08fe - Browse repository at this point
Copy the full SHA 14d08feView commit details
Commits on Dec 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ad9690a - Browse repository at this point
Copy the full SHA ad9690aView commit details
Commits on Dec 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9de273b - Browse repository at this point
Copy the full SHA 9de273bView commit details
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5c6c418 - Browse repository at this point
Copy the full SHA 5c6c418View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.