Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDCConfigReader incompatible to PollingDynamicConfig #509

Open
mseele opened this issue Jul 31, 2017 · 0 comments
Open

JDCConfigReader incompatible to PollingDynamicConfig #509

mseele opened this issue Jul 31, 2017 · 0 comments
Labels
bug v2

Comments

@mseele
Copy link

mseele commented Jul 31, 2017 •
edited
Loading

JDCConfigReader of 2.x branch implements "Callable<Map<String, Object>>" that is incomaptible to PollingDynamicConfig which needs "Callable<PollingResponse>" like URLConfigReader impements.

JDCConfigReader should be changed to implement "Callable<PollingResponse>" instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgallardo-netflix @mseele