Trap exceptions in attribution when symbol entering fails

Netflix-Skunkworks · Aug 23, 2016 · 6842e5f · 6842e5f
1 parent 5692b0f
commit 6842e5f
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 4 deletions.
diff --git a/src/main/kotlin/com/netflix/java/refactor/ast/AstParser.kt b/src/main/kotlin/com/netflix/java/refactor/ast/AstParser.kt
@@ -63,7 +63,12 @@ class AstParser(val classpath: Iterable<Path>?) {
                 .map { compiler.parse(it) }
                 .enterAll()
 
-        compiler.attribute(compiler.todo)
+        try {
+            compiler.attribute(compiler.todo)
+        } catch(ignore: Throwable) {
+            // when symbol entering fails on problems like missing types, attribution can often times proceed
+            // unhindered, but it sometimes cannot (so attribution is always a BEST EFFORT in the presence of errors)
+        }
 
         return cus
     }

diff --git a/...tflix/java/refactor/ast/AstScannerTest.kt → ...etflix/java/refactor/ast/AstParserTest.kt b/...tflix/java/refactor/ast/AstScannerTest.kt → ...etflix/java/refactor/ast/AstParserTest.kt
@@ -10,10 +10,30 @@ import java.nio.file.Files
 import java.util.zip.ZipInputStream
 import kotlin.test.assertEquals
 
-class AstScannerTest : AbstractRefactorTest() {
+class AstParserTest : AbstractRefactorTest() {
+
+    /**
+     * Often type attribution can succeed in spite of symbol entering failures, but there are edge cases
+     * where it does not. Therefore, attribution after symbol entering failures is always a BEST EFFORT only.
+     */
+    @Test
+    fun typeAttributionDoesNotCauseRuntimeExceptionsWhenSymbolEnteringFails() {
+        val a = java("""
+            |import java.util.function.Consumer;
+            |public class A {
+            |    public void fail(){
+            |        Consumer<String> c = s -> {
+            |            Function<String, OOPS> f = s2 -> null;
+            |        };
+            |    }
+            |}
+        """)
+
+        parseJava(a)
+    }
 
     @Test
-    fun scannerIsAbleToIdentifyTypesFromExternalDependencies() {
+    fun parserIsAbleToIdentifyTypesFromExternalDependencies() {
         val a = java("""
             |package a;
             |import org.testng.annotations.*;
@@ -47,7 +67,7 @@ class AstScannerTest : AbstractRefactorTest() {
     // FIXME how to do this?
     @Ignore
     @Test
-    fun scannerIsAbleToLoadExternalDependenciesFromInMemoryFileSystems() {
+    fun parserIsAbleToLoadExternalDependenciesFromInMemoryFileSystems() {
         val fs = MemoryFileSystemBuilder.newEmpty().build("virtual")
         fs.use { fs ->
             val a = fs.getPath("A.java")