Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the startup hook to run asynchronously for mutable content #618

Closed
ghenzler opened this issue Nov 16, 2021 · 2 comments · Fixed by #619
Closed

Allow the startup hook to run asynchronously for mutable content #618

ghenzler opened this issue Nov 16, 2021 · 2 comments · Fixed by #619
Milestone

Comments

@ghenzler
Copy link
Member

ghenzler commented Nov 16, 2021

The AC Tool potentially can run a fairly long time (>1 minute) for mutable content if there is a large magnitude.

For those cases and when being on AEMaaCS having the AC Tool applied to mutable content via Startup Hook, there should be an option to run the AC Tool asynchronously (to not block startup of pods during AEMaaCS deployment)

To start with this option should not be the default, possibly it makes sense to make it the default later.

@kwin
Copy link
Member

kwin commented Nov 17, 2021

IMHO we need to distinguish between the two executions of the startup hook

  1. During the docker build: It must run synchronously as otherwise the AEM instance may be stopped before the hook finished running
  2. During the first real startup we can/should run asynchronously, potentially even with a time delay to make sure that mutable packages are installed first (compare with AEMaaCS: Startup Hook executed too early for ACLs on mutable content #545)

@ghenzler
Copy link
Member Author

exactly, from description:

being on AEMaaCS having the AC Tool applied to mutable content via Startup Hook

this is your case 2

ghenzler added a commit that referenced this issue Nov 18, 2021
…k-to-run-async-for-mutable-content

#618 Allow startup hook to run asynchronously for mutable content
@ghenzler ghenzler added this to the 3.0.4 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants