Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parity] RestPerf Disk Plugin should Support Metric Customization #2450

Closed
rahulguptajss opened this issue Oct 30, 2023 · 1 comment · Fixed by #2573
Closed

[Parity] RestPerf Disk Plugin should Support Metric Customization #2450

rahulguptajss opened this issue Oct 30, 2023 · 1 comment · Fixed by #2573
Assignees
@rahulguptajss
Labels
24.02 feature New feature or request status/done

Comments

@rahulguptajss
Copy link
Contributor

We should enable metric customization in the RestPerf Disk plugin, similiar to functionality in ZapiPerf.
https://github.com/NetApp/harvest/blob/main/conf/zapiperf/cdot/9.8.0/disk.yaml#L54-L96

Refer #2449
@rahulguptajss rahulguptajss added the feature New feature or request label Oct 30, 2023
@rahulguptajss rahulguptajss changed the title [Parity] RestPerf Disk Plugin should Supports Metric Customization [Parity] RestPerf Disk Plugin should Support Metric Customization Oct 30, 2023
@cgrinds cgrinds added the 24.02 label Nov 13, 2023
@Hardikl Hardikl self-assigned this Dec 22, 2023
@Hardikl Hardikl linked a pull request Jan 3, 2024 that will close this issue
feat: RestPerf Disk Plugin should Support Metric Customization #2573
Merged
@rahulguptajss
Copy link
Contributor Author

Verified in main. Works as expected.

There is no available mapping for the ZAPI field initiator-wwpn, which might be a gap for customers who use this field. By default, Harvest doesn't include it.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulguptajss rahulguptajss

Labels
24.02 feature New feature or request status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: RestPerf Disk Plugin should Support Metric Customization NetApp/harvest
3 participants
@cgrinds @rahulguptajss @Hardikl