Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal-C 1.4.4 fails with error message about missing MS1 spectra #8

Open
reid-wagner opened this issue Jun 15, 2022 · 17 comments
Open

Comments

@reid-wagner
Copy link

When I run Crystal-C 1.4.4 I get the following error message with exit code 1:

Please check if there are MS1 spectra in raw or mzML files.

Crystal-C 1.4.2 runs successfully using the same input data and parameters, so I am guessing those are not the issue.

Because I don't see 1.4.4 published here yet, I'll add that I was originally running it via FragPipe 18.0, although I've also run the isolated java command from FragPipe with the same results.

Let me know if I can provide any further information. Thanks!

@huiyinc
Copy link
Collaborator

huiyinc commented Jun 17, 2022 via email

@p-bell
Copy link

p-bell commented Oct 4, 2022

I have the same issue, running FragPipe v18. Crystal-C version mentioned in pep.xml output: 2019.08

I downloaded the following raw files from PRIDE (PXD034135):
TC-EG_CALU_CoV2_WCL_F23.raw
TC-EG_CALU_CoV2_WCL_F24.raw

Then converted the raw files to mzml using msconvert, and ran open mod searches (each file searched individually):

  • TC-EG_CALU_CoV2_WCL_F24.mzml processes without issue.
  • TC-EG_CALU_CoV2_WCL_F23.mzml fails with the following error:
    Please check if there are MS1 spectra in raw or mzML files.

Including both files in the same search gives the same error.

Please let me know if I can provide any other info to help resolve the issue.
Thanks

@huiyinc
Copy link
Collaborator

huiyinc commented Oct 4, 2022 via email

@p-bell
Copy link

p-bell commented Oct 4, 2022

Hi Huiyin,

Thanks for getting back to me and looking into the issue.

The files are large (~1.5Gb each) - how is the best way to get them to you? Is the nesvilab account email address ok for me to send a OneDrive link?

Thanks
Pete

@huiyinc
Copy link
Collaborator

huiyinc commented Oct 5, 2022 via email

@p-bell
Copy link

p-bell commented Oct 5, 2022

Hi Huiyin, sorry I can't see the email address - it appears as @.*** in the browser.

@huiyinc
Copy link
Collaborator

huiyinc commented Oct 6, 2022

Hi Peter,

Thanks for letting me know. My email address is: [email protected].

Huiyin

@p-bell
Copy link

p-bell commented Oct 6, 2022

Thanks - the files should be with you now

@huiyinc
Copy link
Collaborator

huiyinc commented Oct 7, 2022

Hi Peter,

I just perform an open search using FragPipe (Crystal-C v.1.4.3) and the fasta/mzML files you sent. The process works fine. Attached is the log file generated by FragPipe. Can you please tell me which version of Crystal-C you use?
Thanks.

Huiyin

log_2022-10-07_15-23-23.txt

@p-bell
Copy link

p-bell commented Oct 7, 2022

Thanks for looking into it Huiyin.

I also ran it from FragPipe, but it appears to be Crystal-C v.1.4.4 in my installation. (Please see attached log of one of the failed searches):
C:\0-Software\FragPipe-jre-18.0\fragpipe\tools\original-crystalc-1.4.4.jar

Thanks
Pete

log_2022-10-04_17-04-00.txt

@huiyinc
Copy link
Collaborator

huiyinc commented Oct 9, 2022

Hi Peter,

After rechecking Crystal-C and your mzML file, I notice that the library of file reader (batmass-io) is updated to version 1.25.5. In the new version, batmass-io removes MS (MS/MS scans) with no data points. So, a scan (scan number: 91049, TC-EG_CALU_CoV2_WCL_F23.mzML) is excluded (as shown in the attached figure), resulting an exception in Crystal-C.

I have updated Crystal-C to avoid the exception. Can you please download and try the new release? Download link: https://github.com/Nesvilab/Crystal-C/releases/tag/1.5.0

Please feel free to let me know if there is any problem. Thanks.

Huiyin

fig

@p-bell
Copy link

p-bell commented Oct 12, 2022

Hi Huiyin,

That seems to have solved the problem! Searches of that file now complete successfully :)

Thanks a lot for your help and for continuing to develop these tools.

Cheers
Pete

@p-bell
Copy link

p-bell commented Oct 12, 2022

Hi again Huiyin,

Sorry I've encountered the same problem with a different file (I'll send by email).

Please would it be possible to take another look?

Thanks
Pete

@huiyinc
Copy link
Collaborator

huiyinc commented Oct 13, 2022 via email

@p-bell
Copy link

p-bell commented Oct 15, 2022

Thanks Huiyin, I sent the link to the files (Wed 10th) - did you receive it? Please let me know if not and I'll resend.

Cheers
Pete

@huiyinc
Copy link
Collaborator

huiyinc commented Oct 15, 2022 via email

@p-bell
Copy link

p-bell commented Oct 19, 2022

Thanks for looking into it Huiyin.

I look forward to using the new version when it's ready.

Thanks again,
Pete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants