Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-upgrade improvements #34

Open
cristinecula opened this issue Apr 6, 2020 · 0 comments
Open

Post-upgrade improvements #34

cristinecula opened this issue Apr 6, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@cristinecula
Copy link
Collaborator

I still think you should drop the unsubscribeFromEvents call from the source effect destructor
if a source is closed, it won't trigger events anyway
you might as well unsubscribe after closing, it won't matter
this would separate and contain the implementation of the two effects, leading to easier maintenance
I would even wrap the two effects in two useHook-style functions and export those too, along with the component
if someone wants the logic without the component, they are free to use it

Re https://neovici.slack.com/archives/DGX65MV34/p1586154405055700 (private)
Re #33

@cristinecula cristinecula added the enhancement New feature or request label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant