Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common path bug #4

Open
nomego opened this issue Oct 15, 2017 · 2 comments
Open

Common path bug #4

nomego opened this issue Oct 15, 2017 · 2 comments
Assignees

Comments

@nomego
Copy link
Contributor

nomego commented Oct 15, 2017

After d5b895e, I noticed that the paths to render in the cells are calculated the wrong way.
I assume we calculate "number of nodes to show" (from the right) instead of "number of nodes to hide" (from the left) - which doesn't work when the paths have different number of nodes.

See the demo and compare the filtering autocomplete-list with the cells rendered.

Maybe we can define the fix further and reassign it.

@nomego
Copy link
Contributor Author

nomego commented Dec 11, 2017

@plequang was this a non issue?

@plequang
Copy link
Contributor

The code that computes number of nodes to hide is correct.

The problem in the demo is with show-max-nodes, which keeps showMaxNodes from the right.

Was maybe an error to add this option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants