Add more divrem functions

Nemocas · Nov 29, 2024 · 7c7b930 · 7c7b930
1 parent 7d32c4b
commit 7c7b930
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/src/flint/fmpz.jl b/src/flint/fmpz.jl
@@ -661,7 +661,10 @@ divrem(x::ZZRingElem, y::Integer) = divrem(x, ZZRingElem(y))
 
 divrem(x::Integer, y::ZZRingElem) = divrem(ZZRingElem(x), y)
 
-Base.divrem(x::ZZRingElem, y::Integer) = Base.divrem(x, ZZ(y))
+# Without the functions below, Julia defaults to `(div(x, y), rem(x, y))`
+Base.divrem(x::ZZRingElem, y::Integer) = (
+  Base.divrem(x, ZZ(y))
+)
 Base.divrem(x::ZZRingElem, y::Integer, ::typeof(RoundToZero)) = (
   Base.divrem(x, ZZ(y), RoundToZero)
 )
@@ -671,6 +674,18 @@ Base.divrem(x::ZZRingElem, y::Integer, ::typeof(RoundUp)) = (
 Base.divrem(x::ZZRingElem, y::Integer, ::typeof(RoundDown)) = (
   Base.divrem(x, ZZ(y), RoundDown)
 )
+Base.divrem(x::Integer, y::ZZRingElem) = (
+  Base.divrem(ZZ(x), y)
+)
+Base.divrem(x::Integer, y::ZZRingElem, ::typeof(RoundToZero)) = (
+  Base.divrem(ZZ(x), y, RoundToZero)
+)
+Base.divrem(x::Integer, y::ZZRingElem, ::typeof(RoundUp)) = (
+  Base.divrem(ZZ(x), y, RoundUp)
+)
+Base.divrem(x::Integer, y::ZZRingElem, ::typeof(RoundDown)) = (
+  Base.divrem(ZZ(x), y, RoundDown)
+)
 
 ###############################################################################
 #