fix: wrong caching in relative FqField construction (#1952)

* fix: wrong caching in relative FqField construction * chore: bump version
Nemocas · Nov 28, 2024 · 2ead31a · 2ead31a · thofma · Nov 29, 2024
1 parent c77cb33
commit 2ead31a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "Nemo"
 uuid = "2edaba10-b0f1-5616-af89-8c11ac63239a"
-version = "0.47.4"
+version = "0.47.5"
 
 [deps]
 AbstractAlgebra = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"

diff --git a/src/flint/fq_default_extended.jl b/src/flint/fq_default_extended.jl
@@ -616,7 +616,7 @@ function FqField(f::FqPolyRingElem, s::Symbol, cached::Bool = false, absolute::B
       p = characteristic(K)
       d = absolute_degree(K) * degree(f)
       # Construct a "standard" copy of F_p^d
-      L = FqField(p, d, s, cached)
+      L = FqField(p, d, s, false)
       L.isabsolute = absolute
       L.isstandard = false
       L.defining_poly = f

diff --git a/test/flint/fq_default_extended-test.jl b/test/flint/fq_default_extended-test.jl
@@ -104,6 +104,13 @@
   @test F(ZZ["x"][2] + 1) == b + 1
   c = 2b^2 + 2b + 1
   @test lift(Rx, c) == 2x^2 + 2x + 1
+
+  # fix for caching issues
+  R = GF(3, 2)
+  Rx, x = R["x"]
+  f = x
+  F, _ = finite_field(f, "b", cached = true)
+  @test F isa FqField
 end
 
 @testset "FqFieldElem.printing" begin