Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and fix similar and zero for our matrix types #1890

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Simplify and fix similar and zero for our matrix types #1890

merged 9 commits into from
Nov 12, 2024

Commits on Nov 8, 2024

  1. Simplify and fix similar for our matrix types 

    Remove the internal helper `_similar` which untangles the `MatElem` and
`MatRingElem` code further and makes it easier to see what's going on.

Also change `similar` for `MatElem` to default to calling `zero_matrix`.
With this `similar(::ZZMatrix)` in Nemo returns a new `ZZMatrix` instead
of a `AbstractAlgebra.Generic.MatSpaceElem{ZZRingElem}`.
    @fingolfin
    fingolfin committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    addab0c View commit details
    Browse the repository at this point in the history

  2. untangle

    @fingolfin
    fingolfin committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    edf1130 View commit details
    Browse the repository at this point in the history

  3. preserve Generic.MatSpaceElem

    @fingolfin
    fingolfin committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8d64442 View commit details
    Browse the repository at this point in the history

  4. Test more variants of 'similar'

    @fingolfin
    fingolfin committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    bcdee6b View commit details
    Browse the repository at this point in the history

  5. Fix zero(MatrixElem) to call suitable similar methods

    @fingolfin
    fingolfin committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    23d055c View commit details
    Browse the repository at this point in the history

  6. Remove redundant similar method

    @fingolfin
    fingolfin committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f7da828 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Untangle docstrings for similar, zero; MatElem, MatRingElem

    @fingolfin
    fingolfin committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    cea07e2 View commit details
    Browse the repository at this point in the history

  2. Restore similar/zero method for MatRingElem with row *and* column arg 

    These don't really make much sense and I suggest we deprecate them in
the future but for now I want to keep it simple.
    @fingolfin
    fingolfin committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    71d6f09 View commit details
    Browse the repository at this point in the history

  3. fix

    @fingolfin
    fingolfin committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    fd156e4 View commit details
    Browse the repository at this point in the history