Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete redundant isequal method #1875

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Delete redundant isequal method #1875

merged 1 commit into from
Oct 23, 2024

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Oct 18, 2024

The default method already delegates to ==

Extracted from PR #1854

The default method already delegates to ==
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.15%. Comparing base (983f6ec) to head (1690463).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1875      +/-   ##
==========================================
- Coverage   88.15%   88.15%   -0.01%     
==========================================
  Files         120      120              
  Lines       30250    30248       -2     
==========================================
- Hits        26668    26666       -2     
  Misses       3582     3582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to say: the default method in

function isequal(a::RingElem, b::RingElem)
first checks the parents. However, currently the behaviour of both versions is exactly the same because == does not throw an error for TotFracs with different parents.

@joschmitt joschmitt merged commit dd1639b into master Oct 23, 2024
30 checks passed
@joschmitt joschmitt deleted the mh/rm-redundant-isequal branch October 23, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants