julia/Float: x == 0 -> iszero(x)
#1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1870 +/- ##
==========================================
- Coverage 88.17% 88.15% -0.02%
==========================================
Files 120 120
Lines 30220 30250 +30
==========================================
+ Hits 26645 26668 +23
- Misses 3575 3582 +7 ☔ View full report in Codecov by Sentry. |
lgoettgens
approved these changes
Oct 18, 2024
fingolfin
reviewed
Oct 18, 2024
| @@ -91,7 +91,7 @@ divexact(a::Rational{T}, b::AbstractFloat; check::Bool=true) where T <: Union{Si | |||
| divexact(a::Rational{BigInt}, b::BigFloat; check::Bool=true) = a/b | |||
|
|
|||
| function divides(a::BigFloat, b::BigFloat) | |||
There was a problem hiding this comment.
Off-topic, but: why do we define this only for BigFloat, not for AbstractFloat? (or alternatively, why do we define this at all... but I guess that ship has sailed sigh)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1868