-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic == error #1853
base: master
Are you sure you want to change the base?
Add generic == error #1853
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1853 +/- ##
==========================================
- Coverage 88.14% 88.13% -0.01%
==========================================
Files 119 119
Lines 30019 30021 +2
==========================================
Hits 26460 26460
- Misses 3559 3561 +2 ☔ View full report in Codecov by Sentry. |
This causes several errors in OscarCI, which actually make me wonder if there is a bug in code there. Perhaps @ThomasBreuer can have a look? For reference this is the error I see in CI:
|
O.k. I can reproduce the problem locally, and will create a pull request for Oscar.jl that fixes it. |
Closes #1800, resolves oscar-system/Oscar.jl#4107.
This includes only the snippet from #1800 (comment)
cc @joschmitt