Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe funcs for FreeAssAlgebra, Poly, MPoly #1847

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Oct 8, 2024

cc @fingolfin

Resolves #1819

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 99.33775% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.15%. Comparing base (9ebc781) to head (1001697).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/generic/FreeAssociativeAlgebra.jl 99.06% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1847      +/-   ##
==========================================
+ Coverage   88.06%   88.15%   +0.09%     
==========================================
  Files         120      120              
  Lines       30057    30203     +146     
==========================================
+ Hits        26469    26625     +156     
+ Misses       3588     3578      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens marked this pull request as ready for review October 8, 2024 15:37
@lgoettgens
Copy link
Collaborator Author

Rebasing this on top of #1838 somehow broke neg! for universal polynomial rings. I have no idea why. Can you look into this @fingolfin ?

@fingolfin fingolfin merged commit abbe2ac into Nemocas:master Oct 11, 2024
32 checks passed
@lgoettgens lgoettgens deleted the lg/unsafe-freeassalg branch October 11, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mutating arithmetics for FreeAssociativeAlgebraElem
2 participants