Matrix normal forms #1554
Merged
Matrix normal forms #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
force-pushed
the
js/normal_forms
branch
from
20b5e80
to
0a5b049
Compare
joschmitt
commented
Jan 18, 2024
joschmitt
commented
Jan 18, 2024
joschmitt
force-pushed
the
js/normal_forms
branch
2 times, most recently
from
9a502a3
to
3baec01
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
+ Coverage 87.11% 87.13% +0.01%
==========================================
Files 114 115 +1
Lines 29483 29536 +53
==========================================
+ Hits 25685 25735 +50
- Misses 3798 3801 +3 ☔ View full report in Codecov by Sentry. |
joschmitt
force-pushed
the
js/normal_forms
branch
from
3baec01
to
6ea3c1e
Compare
|
I filled the functions with life now by calling |
joschmitt
force-pushed
the
js/normal_forms
branch
from
6ea3c1e
to
0977efc
Compare
|
I am confused. Shouldn't the |
That's done in the in-place version |
|
Ah, I missed it, sorry |
ooinaruhugh
pushed a commit
to ooinaruhugh/AbstractAlgebra.jl
that referenced
this pull request
Feb 15, 2024
* Skeleton for matrix normal forms * Matrix normal forms (by calling existing functions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a uniform interface for normal forms of matrices (in context with OSCAR 1.0).
I already open this pull request now to check whether I understood the HackMD correctly. (There is no actual functionality yet.)