Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more functionality for matrices over NCRing #1499

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

lgoettgens
Copy link
Collaborator

Continuation of #1443.

Changed functions:

  • handling CartesianIndex

  • setindex!

  • trace tr

  • row and column permutations and swaps

  • adjusted docstrings of earlier changed functions

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1499 (30ba8bf) into master (1a90775) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   86.74%   86.73%   -0.01%     
==========================================
  Files         111      111              
  Lines       28833    28833              
==========================================
- Hits        25010    25009       -1     
- Misses       3823     3824       +1     
Files Coverage Δ
src/Matrix.jl 91.75% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@lgoettgens lgoettgens changed the title Enable more functionality for matrices of NCRing Enable more functionality for matrices over NCRing Nov 9, 2023
@thofma thofma enabled auto-merge (squash) November 9, 2023 15:35
@thofma thofma merged commit e578d4a into Nemocas:master Nov 9, 2023
14 of 15 checks passed
@lgoettgens lgoettgens deleted the lg/NCRing-matrix branch November 16, 2023 10:20
fingolfin pushed a commit to mgkurtz/AbstractAlgebra.jl that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants