Remove redundant 'convert' invocation #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already a type assertion inside the code, so no need for this conversion inducing type declaration.
Codecov Report
@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
+ Coverage 86.85% 86.92% +0.07%
==========================================
Files 110 110
Lines 28650 28879 +229
==========================================
+ Hits 24884 25104 +220
- Misses 3766 3775 +9
... and 19 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
lgoettgens
approved these changes
Nov 3, 2023
|
The OscarCI needs #1488 to be available. |
fingolfin
added a commit
to mgkurtz/AbstractAlgebra.jl
that referenced
this pull request
Nov 21, 2023
There is already a type assertion inside the code, so no need for this conversion inducing type declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a type assertion inside the code, so no
need for this conversion inducing type declaration.