Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix printing multivariate polynomial ring with many variables (#1476)" #1488

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

thofma
Copy link
Member

@thofma thofma commented Nov 2, 2023

Just so that we have a working downstream CI.

@thofma thofma requested a review from fingolfin November 2, 2023 18:18
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1488 (37b7d25) into master (78a01de) will decrease coverage by 0.04%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
- Coverage   86.85%   86.82%   -0.04%     
==========================================
  Files         110      110              
  Lines       28650    28673      +23     
==========================================
+ Hits        24884    24895      +11     
- Misses       3766     3778      +12     
Files Coverage Δ
src/AbsMSeries.jl 95.96% <50.00%> (ø)
src/FreeAssAlgebra.jl 95.93% <0.00%> (ø)
src/LaurentMPoly.jl 95.89% <50.00%> (ø)
src/MPoly.jl 76.03% <33.33%> (-1.84%) ⬇️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@fingolfin
Copy link
Member

One OscarCI test had a timeout, I just restarted it.

@fingolfin
Copy link
Member

Actually, I'll just merge this: the other OscarCI test was fixed, and I see no way how this could break more. Most likely the OscarCI test just failed randomly, as they are prone to do right now. If not, then it's unlikely this PR is at fault, it will be something else that we should analyze separately then

@fingolfin fingolfin merged commit ddeefc6 into master Nov 3, 2023
13 of 17 checks passed
@fingolfin fingolfin deleted the th/revrev branch November 3, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants