Resolve ambiguity between divexact methods #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1484 +/- ##
=======================================
Coverage 86.86% 86.87%
=======================================
Files 110 110
Lines 28664 28668 +4
=======================================
+ Hits 24900 24904 +4
Misses 3764 3764
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Do you have an example? Or was this reported from JET? |
|
This was reported by JET, but you are right, an example (added as a test case) would be good. I'll look into it. |
|
Err, Aqua reported it, not JET |
fingolfin
force-pushed
the
mh/divexact-ambiguity
branch
from
82e5c4c to
0e03683
Compare
fingolfin
commented
Nov 4, 2023
| @test divexact(2, y) * y == 2 | ||
| @test divexact(big(2), y) * y == 2 | ||
| @test divexact(1//2, y) * y == 1//2 | ||
| @test divexact(big(1)//2, y) * y == 1//2 |
There was a problem hiding this comment.
This last new test results in an ambiguity error on master, and is fixed by this PR.
|
Thanks |
fingolfin
added a commit
to mgkurtz/AbstractAlgebra.jl
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.