Skip to content

Commit

Permalink
Resolve ambiguity between divexact methods
Browse files Browse the repository at this point in the history
  • Loading branch information
fingolfin committed Nov 1, 2023
1 parent 93be9a0 commit 82e5c4c
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions src/generic/FunctionField.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1027,12 +1027,22 @@ function divexact(a::FunctionFieldElem, b::RingElem; check::Bool=true)
end

function divexact(a::Union{Rational, Integer},
b::FunctionFieldElem; check::Bool=true)
b::FunctionFieldElem{T}; check::Bool=true) where T <: FieldElement
return a*inv(b)
end

function divexact(a::T,
b::FunctionFieldElem{T}; check::Bool=true) where T <: FieldElement
b::FunctionFieldElem{T}; check::Bool=true) where T <: Integer
return a*inv(b)

Check warning on line 1036 in src/generic/FunctionField.jl

View check run for this annotation

Codecov / codecov/patch

src/generic/FunctionField.jl#L1036

Added line #L1036 was not covered by tests
end

function divexact(a::T,

Check warning on line 1039 in src/generic/FunctionField.jl

View check run for this annotation

Codecov / codecov/patch

src/generic/FunctionField.jl#L1039

Added line #L1039 was not covered by tests
b::FunctionFieldElem{T}; check::Bool=true) where T <: Rational
return a*inv(b)

Check warning on line 1041 in src/generic/FunctionField.jl

View check run for this annotation

Codecov / codecov/patch

src/generic/FunctionField.jl#L1041

Added line #L1041 was not covered by tests
end

function divexact(a::T,

Check warning on line 1044 in src/generic/FunctionField.jl

View check run for this annotation

Codecov / codecov/patch

src/generic/FunctionField.jl#L1044

Added line #L1044 was not covered by tests
b::FunctionFieldElem{T}; check::Bool=true) where T <: FieldElem
return a*inv(b)
end

Expand Down

0 comments on commit 82e5c4c

Please sign in to comment.