Improve type stability

Nemocas · Jan 17, 2024 · 2e4f705 · 2e4f705
1 parent fa5f5d0
commit 2e4f705
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/Solve.jl b/src/Solve.jl
@@ -10,16 +10,16 @@ import AbstractAlgebra: base_ring, nrows, ncols
 #
 ################################################################################
 
-mutable struct LazyTransposeMatElem{T} <: MatElem{T}
-  M::MatElem{T}
+mutable struct LazyTransposeMatElem{T, MatT} <: MatElem{T} where {MatT <: MatElem{T}}
+  M::MatT
 end
 
 data(M::LazyTransposeMatElem) = M.M
 
 # The entries of M and the result are SHARED, so e.g. a setindex! will modify
 # 'both' matrices. But this is the point: we don't want to actually transpose
 # the matrix.
-lazy_transpose(M::MatElem) = LazyTransposeMatElem(M)
+lazy_transpose(M::MatElem{T}) where T = LazyTransposeMatElem{T, typeof(M)}(M)
 lazy_transpose(M::LazyTransposeMatElem) = data(M)
 
 # Change the order of rows and columns in nrows, ncols, getindex and setindex!

diff --git a/test/Solve-test.jl b/test/Solve-test.jl
@@ -57,8 +57,8 @@ end
   M = matrix(QQ, [1 2 3 4 5; 0 0 8 9 10; 0 0 0 14 15])
   MT = AbstractAlgebra.Solve.lazy_transpose(M)
 
-  @test AbstractAlgebra.Solve.data(MT) === M
-  @test AbstractAlgebra.Solve.lazy_transpose(MT) === M
+  @test @inferred AbstractAlgebra.Solve.data(MT) === M
+  @test @inferred AbstractAlgebra.Solve.lazy_transpose(MT) === M
   @test transpose(M) == MT
 
   @test nrows(MT) == 5
@@ -71,16 +71,16 @@ end
 
   @test base_ring(MT) == QQ
 
-  @test zero(MT) == AbstractAlgebra.Solve.lazy_transpose(zero_matrix(QQ, 3, 5))
-  @test zero(MT, 2, 3) == AbstractAlgebra.Solve.lazy_transpose(zero_matrix(QQ, 3, 2))
+  @test @inferred zero(MT) == AbstractAlgebra.Solve.lazy_transpose(zero_matrix(QQ, 3, 5))
+  @test @inferred zero(MT, 2, 3) == AbstractAlgebra.Solve.lazy_transpose(zero_matrix(QQ, 3, 2))
 
-  S = similar(MT)
+  S = @inferred similar(MT)
   @test S isa AbstractAlgebra.Solve.LazyTransposeMatElem
   @test nrows(S) == 5
   @test ncols(S) == 3
   @test base_ring(S) == QQ
 
-  S = similar(MT, 2, 3)
+  S = @inferred similar(MT, 2, 3)
   @test S isa AbstractAlgebra.Solve.LazyTransposeMatElem
   @test nrows(S) == 2
   @test ncols(S) == 3