Cleanup warnings generated in new Elixir versions

lib/sage.ex

@@ -408,7 +408,7 @@ defmodule Sage do
 
   Ecto must be included as application dependency.
   """
-  @since "0.3.3"
+  @doc since: "0.3.3"
   @spec transaction(sage :: t(), repo :: module(), opts :: any()) ::
           {:ok, result :: any(), effects :: effects()} | {:error, any()}
   def transaction(%Sage{} = sage, repo, opts \\ []) do

lib/sage/executor.ex

@@ -158,37 +158,37 @@ defmodule Sage.Executor do
   end
 
   defp apply_transaction_fun(name, {mod, fun, args} = mfa, effects_so_far, opts) do
-    apply(mod, fun, [effects_so_far, opts | args])
-  else
-    {:ok, effect} ->
-      {:ok, effect}
+    case apply(mod, fun, [effects_so_far, opts | args]) do
+      {:ok, effect} ->
+        {:ok, effect}
 
-    {:error, reason} ->
-      {:error, reason}
+      {:error, reason} ->
+        {:error, reason}
 
-    {:abort, reason} ->
-      {:abort, reason}
+      {:abort, reason} ->
+        {:abort, reason}
 
-    other ->
-      {:raise,
-       {%Sage.MalformedTransactionReturnError{stage: name, transaction: mfa, return: other}, System.stacktrace()}}
+      other ->
+        {:raise,
+         {%Sage.MalformedTransactionReturnError{stage: name, transaction: mfa, return: other}, System.stacktrace()}}
+    end
   end
 
   defp apply_transaction_fun(name, fun, effects_so_far, opts) do
-    apply(fun, [effects_so_far, opts])
-  else
-    {:ok, effect} ->
-      {:ok, effect}
+    case apply(fun, [effects_so_far, opts]) do
+      {:ok, effect} ->
+        {:ok, effect}
 
-    {:error, reason} ->
-      {:error, reason}
+      {:error, reason} ->
+        {:error, reason}
 
-    {:abort, reason} ->
-      {:abort, reason}
+      {:abort, reason} ->
+        {:abort, reason}
 
-    other ->
-      {:raise,
-       {%Sage.MalformedTransactionReturnError{stage: name, transaction: fun, return: other}, System.stacktrace()}}
+      other ->
+        {:raise,
+         {%Sage.MalformedTransactionReturnError{stage: name, transaction: fun, return: other}, System.stacktrace()}}
+    end
   end
 
   defp handle_transaction_result({:start_compensations, state}), do: {:start_compensations, state}

lib/sage/inspect.ex

@@ -10,7 +10,7 @@ defimpl Inspect, for: Sage do
   def inspect(sage, opts) do
     list = to_list(sage)
     left = concat(["#Sage", format_compensation_error_handler(sage.on_compensation_error), "<"])
-    surround_many(left, list, ">", opts, fn str, _ -> str end)
+    container_doc(left, list, ">", opts, fn str, _ -> str end)
   end
 
   defp to_list(sage) do

test/sage/executor/retries_test.exs

@@ -71,6 +71,6 @@ defmodule Sage.Executor.RetriesTest do
     retry? = retry_with_backoff?(count, opts)
     stop = System.monotonic_time()
     assert retry?
-    div(System.convert_time_unit(stop - start, :native, :micro_seconds), 100) / 10
+    div(System.convert_time_unit(stop - start, :native, :microsecond), 100) / 10
   end
 end

test/sage/executor_test.exs

@@ -853,13 +853,13 @@ defmodule Sage.ExecutorTest do
       for step <- [:step1, :step2, :step3, :step4, :step5] do
         assert_receive {^step, :start_transaction, _tracing_state}
         assert_receive {^step, :finish_transaction, time_taken, _tracing_state}
-        assert div(System.convert_time_unit(time_taken, :native, :micro_seconds), 100) / 10 > 0.9
+        assert div(System.convert_time_unit(time_taken, :native, :microsecond), 100) / 10 > 0.9
       end
 
       for step <- [:step1, :step2, :step3, :step4, :step5] do
         assert_receive {^step, :start_compensation, _tracing_state}
         assert_receive {^step, :finish_compensation, time_taken, _tracing_state}
-        assert div(System.convert_time_unit(time_taken, :native, :micro_seconds), 100) / 10 > 0.9
+        assert div(System.convert_time_unit(time_taken, :native, :microsecond), 100) / 10 > 0.9
       end
     end
   end