Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleCloud formatter, option to have all error logs as ReportErrorEvent #139

Open
amozoss opened this issue Oct 16, 2024 · 2 comments
Open

Comments

@amozoss
Copy link

amozoss commented Oct 16, 2024

Thanks for the awesome library.

I was curious how I might go about adding the option to have all Logger.error to always include the following

"@type": "type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent",

https://github.com/Nebo15/logger_json/blob/master/lib/logger_json/formatters/google_cloud.ex#L217

Right now, it seems it just reports the ones that crash or have stack traces.

I'd like to have gcp error reporting for every error log.

Can you point me in the right direction?

@amozoss
Copy link
Author

amozoss commented Oct 21, 2024

Something like this is what I need

master...amozoss:logger_json:master

Have any opinions on how the option is structured for this?

@AndrewDryga
Copy link
Member

I think it's a good addition, I did not have time for OS for a few weeks but now I'm back and will take care of it 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants