-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTypeWriter Extension 0.5.9 expecting OriginalDefinition for CustomFunction, but NTypeWriter.CodeModel is only 0.5.8 #126
Comments
That is interesting, are you using the NT source generator in that project too? |
Yes @NeVeSpl, that is correct |
I have released version 0,5.9.1 of VS add-in, could you check if that helps? The problem is that both VS add-in and source generator are loaded and running in the same VS app domain. dlls are strongly signed so it should work even when different versions of the same assembly are loaded in the app domain... |
Appreciate the speedy updates and insight. Looks like 0.5.9.1 still throws the same error: And OriginalDefinition is still unavailable. |
Not sure if this has any bearing on this issue but I did notice that the vsix file for 0.5.8 was 17.7MB and the vsix file for 0.5.9 was only 3.9MB. Was something missing from the new version. |
It was caused by updating Microsoft.VSSDK.BuildTools nuget from 17.7.2196 to 17.11.435. Much fewer files are now included in the vsix file, and it looks like DLLs distributed with VS are no longer included in the vsix file after the update. |
The v0.5.9 nuggets and source generator have been published. They should match the ones used by the latest version of the VS add-in, and solve this problem. |
Using the latest version of the extension (installed via visual studio) is causing a rendering failed issue for custom functions that implement IType:
error CS0535: 'CustomFunction.WrappedType' does not implement interface member 'IType.OriginalDefinition'
However, OriginalDefinition is not available on the current 0.5.8 version of NTypeWriter.CodeModel.
There does not seem to be a way to roll back to NTypeWriter 0.5.8, nor is there a newer version of the CodeModel to update the package to.
The text was updated successfully, but these errors were encountered: