Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTypeWriter Extension 0.5.9 expecting OriginalDefinition for CustomFunction, but NTypeWriter.CodeModel is only 0.5.8 #126

Open
ndollesin-prismhr opened this issue Oct 16, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@ndollesin-prismhr
Copy link

Using the latest version of the extension (installed via visual studio) is causing a rendering failed issue for custom functions that implement IType:

error CS0535: 'CustomFunction.WrappedType' does not implement interface member 'IType.OriginalDefinition'

However, OriginalDefinition is not available on the current 0.5.8 version of NTypeWriter.CodeModel.

There does not seem to be a way to roll back to NTypeWriter 0.5.8, nor is there a newer version of the CodeModel to update the package to.

@NeVeSpl NeVeSpl self-assigned this Oct 17, 2024
@NeVeSpl NeVeSpl added the bug Something isn't working label Oct 17, 2024
@NeVeSpl
Copy link
Owner

NeVeSpl commented Oct 17, 2024

That is interesting, are you using the NT source generator in that project too?

@ndollesin-prismhr
Copy link
Author

Yes @NeVeSpl, that is correct

@NeVeSpl
Copy link
Owner

NeVeSpl commented Oct 17, 2024

I have released version 0,5.9.1 of VS add-in, could you check if that helps?
If not, the NT source generator will be released soon with matching dlls versions.

The problem is that both VS add-in and source generator are loaded and running in the same VS app domain. dlls are strongly signed so it should work even when different versions of the same assembly are loaded in the app domain...

@ndollesin-prismhr
Copy link
Author

Appreciate the speedy updates and insight.

Looks like 0.5.9.1 still throws the same error:
error CS0535: 'CustomFunction.WrappedType' does not implement interface member 'IType.OriginalDefinition'

And OriginalDefinition is still unavailable.

@rhilton66
Copy link

Not sure if this has any bearing on this issue but I did notice that the vsix file for 0.5.8 was 17.7MB and the vsix file for 0.5.9 was only 3.9MB. Was something missing from the new version.

@NeVeSpl
Copy link
Owner

NeVeSpl commented Oct 18, 2024

Not sure if this has any bearing on this issue but I did notice that the vsix file for 0.5.8 was 17.7MB and the vsix file for 0.5.9 was only 3.9MB. Was something missing from the new version.

It was caused by updating Microsoft.VSSDK.BuildTools nuget from 17.7.2196 to 17.11.435. Much fewer files are now included in the vsix file, and it looks like DLLs distributed with VS are no longer included in the vsix file after the update.

@NeVeSpl
Copy link
Owner

NeVeSpl commented Oct 19, 2024

The v0.5.9 nuggets and source generator have been published. They should match the ones used by the latest version of the VS add-in, and solve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants