Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3d adjoint filters #2018

Open
stevengj opened this issue Mar 24, 2022 · 3 comments
Open

3d adjoint filters #2018

stevengj opened this issue Mar 24, 2022 · 3 comments

Comments

@stevengj
Copy link
Collaborator

It would be good to make the adjoint code dimension-agnostic, i.e. it should work for any Lx × Ly × Lz material grid and do filtering along all of the axes, specializing to 2d or 1d filters when one or two of the dimensions are zeros.

cc @smartalecH

@mochen4, when you were trying out full 3d TO, were you just skipping filtering?

@smartalecH
Copy link
Collaborator

I think Mo was using #1625, which is dimension-agnostic.

I started making #2016 dimension-agnostic as well but figured it would be best to implement that in a new PR. Doing so is rather straightforward, luckily.

@mochen4
Copy link
Collaborator

mochen4 commented Mar 25, 2022

I think Mo was using #1625, which is dimension-agnostic.

That's right. I used the filters.py from that branch.

@smartalecH
Copy link
Collaborator

(cc @mawc2019 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants