-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paddle backend #318
Add paddle backend #318
Conversation
3ce4189
to
58769e8
Compare
Did you forget to include |
58769e8
to
142538d
Compare
142538d
to
7f5acd7
Compare
Thank you for the very nice PR! This is really well done, we are aiming to merge this with our 1.4.0 release this week. |
Add paddle backend to warp Closes GH-318 See merge request omniverse/warp!762
Thanks a lot to @mmacklin and @shi-eric for your review. Note that there seems still a link error in |
Yeah, I fixed that with ab147a0 so we're all good. I did notice that when I tried to install Paddle (CUDA 12.3) and run |
Thanks for fixing that, I found it may because not setting |
Category
Description
As talked in #285, we add PaddlePaddle framework as one of backends of warp.
Thanks for reply from @shi-eric(#313 (comment)), I create this PR as contained only one commit.
This PR additionally adds support for the bool type to warp’s dlpack, based on this discussion: dmlc/dlpack#75 and the corresponding PR: dmlc/dlpack#76. The boolean type representation seems uses 8 bits instead of the current 1 bit finally. I am not sure if there were any additional considerations regarding this in warp’s development. If there are specific explanations, please let me know. I will adjust the support for the boolean type of paddle, according to the suggestions, thanks :).
run test:
todolist:
__cuda_array_interface__
in paddlepaddle([API] Add__cuda_array_interface__
for eager Tensor PaddlePaddle/Paddle#68192)Changelog
Before your PR is "Ready for review"
stubs.py
,functions.rst
)?ruff check
andruff format --check
?