Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate max_text_bytes_per_part #331

Open
sarahyurick opened this issue Oct 28, 2024 · 1 comment · May be fixed by #385
Open

Deprecate max_text_bytes_per_part #331

sarahyurick opened this issue Oct 28, 2024 · 1 comment · May be fixed by #385
Assignees
@sarahyurick
Labels
enhancement New feature or request

Comments

@sarahyurick
Copy link
Collaborator

We have long strings support in cuDF now, so we can deprecate the max_text_bytes_per_part parameter.

Related:
@sarahyurick sarahyurick added the enhancement New feature or request label Oct 28, 2024
@sarahyurick sarahyurick self-assigned this Oct 28, 2024
This was referenced Oct 28, 2024
Closed
Closed
@sarahyurick
Copy link
Collaborator Author

Will work on this after #316 is resolved.

@sarahyurick sarahyurick linked a pull request Nov 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahyurick sarahyurick

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove max_text_bytes_per_part sarahyurick/NeMo-Curator
1 participant
@sarahyurick