Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust anchor link behavior so targets aren't obscured by nav #56

Open
emilywithrow opened this issue Sep 23, 2015 · 5 comments
Open

Adjust anchor link behavior so targets aren't obscured by nav #56

emilywithrow opened this issue Sep 23, 2015 · 5 comments

Comments

@emilywithrow
Copy link

No description provided.

@JoeGermuska
Copy link
Member

if you just put id elements on things, it should probably work. If you want the system to generate IDs, then we need to figure out how you know what will get generated.

@JoeGermuska
Copy link
Member

verified that it works, although the anchor ends up under the 'learn-nav' so we might need to make some systematic adjustment. Do you need more tooling than that?

@JoeGermuska JoeGermuska changed the title Deep linking—can we do it? Adjust anchor link behavior so targets aren't obscured by nav Oct 9, 2015
@emilywithrow
Copy link
Author

Works well but the nav is still hiding the anchor... prob just a quick CSS fix.

@JoeGermuska
Copy link
Member

small thing: whenever possible, please include explicit instructions about how to see a problem case, so we don't have to go hunting around to reconstruct it.

@JoeGermuska
Copy link
Member

So, working with this one https://learn.knightlab.com/lesson/write-some-html/#imgExplainer

I find that my first few experiments with scrollBy or padding the body don't do much, even though some web searches suggest that this is the way. I wonder if the underlying issue is with the dynamics of the page-manager ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants