Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showCredits option entirely useless #189

Open
ilyvion opened this issue Nov 10, 2024 · 0 comments
Open

showCredits option entirely useless #189

ilyvion opened this issue Nov 10, 2024 · 0 comments

Comments

@ilyvion
Copy link

ilyvion commented Nov 10, 2024

Because of this logic

if (this.imgBefore.credit || this.imgAfter.credit) {
this.options.showCredits = true;
} else {
this.options.showCredits = false;
}

which takes place after options are copied into this.options, it doesn't matter whether you pass showCredits in options or not, the only thing that matters is whether or not the images arguments have credit values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant