Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom_sequence option not supported via URL parameter #829

Open
JoeGermuska opened this issue Apr 20, 2023 · 1 comment · May be fixed by #837
Open

zoom_sequence option not supported via URL parameter #829

JoeGermuska opened this issue Apr 20, 2023 · 1 comment · May be fixed by #837

Comments

@JoeGermuska
Copy link
Member

Via ZenDesk, a user reported that a timeline URL including the fragment &zoom_sequence=[0.5,1,2,3,5,8,13,21,34,55,89] did not achieve the desired effect, and, in fact, broke the zoom function.

This is one of the exceptions noted on the options documentation page, "you can pass most of these as URL parameters" (emphasis added).

At its heart is that TimelineJS accepts most options passed in the constructor as strings (see this code). There's special handling for default_bg_color, to see if it is passed as a string.

At a minimum, the Zoom function should not fail if a String value is provided for this option. It could be rejected, or, if done safely, possibly converted into a true array. (safely means no eval of course).

Of course, this option can be passed as an array if a timeline is initialized via javascript code; the issue only arises when it is passed as a URL parameter to the embed page.

@otacke otacke linked a pull request Jun 19, 2023 that will close this issue
@otacke
Copy link

otacke commented Sep 27, 2023

Hi! Just wanted to hint to #837 which should resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants