Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in Jupyter notebook example reading OpenFAST ascii outputs #24

Open
rclarke17 opened this issue Feb 13, 2024 · 5 comments
Open

error in Jupyter notebook example reading OpenFAST ascii outputs #24

rclarke17 opened this issue Feb 13, 2024 · 5 comments

Comments

@rclarke17
Copy link

When I try running the jupyter notebook example I get an error in the section "Interacting with output files" when it tries reading my OpenFAST ASCII output files.
The error originates in line 460 of openfast.py. I believe I was able to fix it by specifying 'latin-1' within the decode method. But am unsure how robust that fix is.

@gbarter
Copy link
Collaborator

gbarter commented Feb 14, 2024

Can you include a screenshot or copy-paste the error info? I just tried the example.ipynb notebook and it works fine. Just to be sure, I am also adding it into the regular CI tests. I also labelled the other notebook (on batch_processing) as deprecated because that uses very old syntax.

@rclarke17
Copy link
Author

rclarke17 commented Feb 15, 2024

image

This error goes away once I specify 'latin-1' in the .decode on line 460 of openfast.py

@gbarter
Copy link
Collaborator

gbarter commented Feb 15, 2024

Hmm, a little surprised by that. Do you know how to submit a PR back to the code with your changes?

@rclarke17
Copy link
Author

Yeah, I can do that if you'd like

@gbarter
Copy link
Collaborator

gbarter commented Feb 16, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants