Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fre.cmor.cmor_mixer more configurable and less hard-code dependent #228

Closed
ilaflott opened this issue Oct 28, 2024 · 1 comment · May be fixed by #227
Closed

make fre.cmor.cmor_mixer more configurable and less hard-code dependent #228

ilaflott opened this issue Oct 28, 2024 · 1 comment · May be fixed by #227
Assignees

Comments

@ilaflott
Copy link
Member

will be closed by picking up #227 and running with it

@ilaflott ilaflott added documentation Improvements or additions to documentation enhancement New feature or request priority: MEDIUM labels Oct 28, 2024
@ilaflott ilaflott linked a pull request Oct 28, 2024 that will close this issue
@ilaflott ilaflott self-assigned this Oct 28, 2024
@ilaflott ilaflott removed documentation Improvements or additions to documentation enhancement New feature or request priority: MEDIUM labels Nov 15, 2024
@ilaflott
Copy link
Member Author

ilaflott commented Dec 6, 2024

closing as this is superseded by #232. That issue contains a sample of a way to gut cmor_mixer's hard-code and put it elsewhere. I'm not convinced this is worth acting on yet, and i'm not convinced the amount of hard-coded parameters is the primary source of pain- it's the gigantic problem space.

@ilaflott ilaflott closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant