Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up fre app regrid path handling #203

Open
ilaflott opened this issue Oct 9, 2024 · 0 comments
Open

clean up fre app regrid path handling #203

ilaflott opened this issue Oct 9, 2024 · 0 comments

Comments

@ilaflott
Copy link
Member

ilaflott commented Oct 9, 2024

Is your feature request related to a problem? Please describe.
data movement in regridding routines is surprisingly tricky. When i rewrote the shell version of regrid-xy, i focused more on nailing down the overall functionality of the script and the underlying fregrid call. While that had benefits to getting the ball rolling, the current path handling scheme seems slightly prone to issues.

Describe the solution you'd like
A lot of the what the script currently does is handle paths/manipulations of such as strings, and then, at the last possible moment, type-cast those strings as pathlib.Path for e.g. a .unlink() or .exists() call.

Additional context
@ceblanton took a whack at this in this PR here and described the issues in an issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant