Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji to readme #3

Open
sonalkr132 opened this issue Nov 13, 2016 · 10 comments
Open

Add emoji to readme #3

sonalkr132 opened this issue Nov 13, 2016 · 10 comments

Comments

@sonalkr132
Copy link
Member

Yes, we love emojies 😍 and we want to use them everywhere 🌍 . Add appropriate emojies to readme.md 📖

Checkout emoji cheatsheet ❤️

@abhay-raizada
Copy link
Member

please point out what you meant by everywhere? do you mean every sentence?

@sonalkr132
Copy link
Member Author

I wouldn't suggest any hard limit 😝 Anything around 5-10 should look good.

@ghost
Copy link

ghost commented Aug 3, 2017

This issue is still around?
Well i guess its there to be my first contribution 😄

@ananyo2012
Copy link
Member

@novice-97 Yup go ahead and make your first PR!

@ghost
Copy link

ghost commented Aug 3, 2017

Yes Sir working on it 😄

@ghost
Copy link

ghost commented Aug 3, 2017

Done Sir. Please review the PR 😁

@ananyo2012
Copy link
Member

@novice-97 Please just call me by my name. Reviewing it.

@ghost
Copy link

ghost commented Aug 5, 2017

@ananyo2012 I made a lot of useless commits unintentionally and then tried
a hard reset to delete those but somehow went 7 commits behind the NIT-DGP branch, so
I deleted my fork. Sorry about that 😅 I'll start over by forking once more.

@abhay-raizada
Copy link
Member

@novice-97 you can go the easy way by deleting your fork or you can also learn git rebase that'll save you a lot of time and that is how everybody else revises when he does something wrong.

@ghost
Copy link

ghost commented Aug 9, 2017

@abhsag24 Thanks for the tip 😄
Btw shouldn't this issue be closed, since my pr was merged? or i guess you guys'll still have it open for more newcomers 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants