Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function plot_line() is not documented and also has some errors and typos #85

Open
realsdx opened this issue Feb 1, 2018 · 1 comment

Comments

@realsdx
Copy link
Contributor

realsdx commented Feb 1, 2018

In line 144 argument variable 'file_paths' should be 'file_path'
https://github.com/NITDgpOS/PlotIt/blob/master/plotit.py#L144

In Line 112 'options.line' should not be inside an else block.
In file 'plotutil.py' in 'plt.title' there should be no 'func' variable-
https://github.com/NITDgpOS/PlotIt/blob/master/lib/plotutil.py#L116

I already solved these issues .. should i do a PR now?

Also, the line plotting function should be documented.

@djmgit
Copy link
Member

djmgit commented Feb 1, 2018

@realsdx Hi, thanks for looking into it. Please go forward send a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants