Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code #46

Open
djmgit opened this issue Nov 23, 2017 · 5 comments
Open

Remove redundant code #46

djmgit opened this issue Nov 23, 2017 · 5 comments

Comments

@djmgit
Copy link
Member

djmgit commented Nov 23, 2017

In lib/plotutil.py, the functions plot and plot_line has many elements in common. Try to merge plot_line into plot. Use a flag (or any other method) to determine whether a function is to be plotted or two lists of x and y has to be plotted and do both the stuff in the same function. In this way the repeated code can be removed.

@djmgit djmgit added the hard label Nov 23, 2017
@LoneOne123
Copy link
Contributor

@djmgit i've done this, so when u merged the typo from me from rahuldcoder (cause i corrected this on my local already and don't want to steal his solution :D), then i will commit it and open a PR ;)
with flag u mean an additional argument to the plot function right?
greets

@djmgit
Copy link
Member Author

djmgit commented Nov 26, 2017

@LoneOne123 yes, by flag I mean an additional argument.

@LoneOne123
Copy link
Contributor

so sry have had an exam yesterday and my ssd died :(
now i have a bit time and have a look at all again and will solve this issue in the next days.

@LoneOne123
Copy link
Contributor

@djmgit here we go, but it still just works with [array1][array2] and not with [array1],[array2]
if u want i can switch it, but i think we dont need the comma,
or i can try to make it work with both
greets

@djmgit
Copy link
Member Author

djmgit commented Dec 15, 2017

@LoneOne123 no problem, its great that you are still continuing to work on this :)
Changes look good, send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants