aligned text with button #314
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #314 +/- ##
========================================
Coverage 88.97% 88.97%
========================================
Files 175 175
Lines 3311 3312 +1
Branches 834 834
========================================
+ Hits 2946 2947 +1
Misses 365 365
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Process-ing
requested changes
Mar 13, 2023
| const disabled = Object.keys(items).length <= 1; | ||
| return ( | ||
| <FormControl> | ||
| <span> | ||
| <IconButton | ||
| aria-label={`Remove Entry ${i}`} | ||
| onClick={onClick} | ||
| className={classes.buttom} | ||
| disabled={disabled} |
There was a problem hiding this comment.
buttom is triggering my OCD.
| @@ -1,6 +1,9 @@ | |||
| import { makeStyles } from "@material-ui/styles"; | |||
|
|
|||
| export default makeStyles(() => ({ | |||
| buttom: { | |||
| bottom: "10px", | |||
| }, | |||
|
@letziou updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the meeting I removed the textFieldProps={{ multiline: true }} option from the requirements textField and then adjusted the position of the remove entry button to align with the text.
Closes #262