Update ErrorSummary component to forward refs #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for things like programmatic keyboard focus in order to fulfil accessibility requirements.
eatoncns
force-pushed
the
forward-ref-error-summary
branch
from
b78a993 to
f0a374c
Compare
Tomdango
added a commit
that referenced
this pull request
Apr 13, 2023
* Add dev warnings for v5 breaking changes (#150) * Add deprecation warning to footer columns prop * Shared warning object for v5 * Dev warning for DoDontList.tsx * Dev warning for TransactionalServiceName.tsx * Dev warning for ReviewDate.tsx * Lint --------- Co-authored-by: Thomas Judd-Cooper <[email protected]> * Fix Readme CI Build status tag (#149) Co-authored-by: Thomas Judd-Cooper <[email protected]> * Only run CI on main and PR's (#148) Currently ci build will run on any push and any pull_request. Pushing to a feature branch kicks off CI unintentionally. Co-authored-by: Thomas Judd-Cooper <[email protected]> * Bump ansi-regex from 4.1.0 to 4.1.1 (#156) Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Judd-Cooper <[email protected]> * Bump minimatch from 3.0.4 to 3.1.2 (#155) Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Judd-Cooper <[email protected]> * Update ErrorSummary component to forward refs (#135) This allows for things like programmatic keyboard focus in order to fulfil accessibility requirements. Co-authored-by: Phil Meier <[email protected]> Co-authored-by: Thomas Judd-Cooper <[email protected]> * bug/Checkbox declaration file inconsistency (#133) * Add "strictNullChecks", fix two cases where typing needs updating in line with checks. * Revert to .defaultProps * Throw error on default HeadingLevel.tsx case * Warn on invalid prop, test to cover * Better dev warning for heading level --------- Co-authored-by: Thomas Judd-Cooper <[email protected]> * Add aria-controls * Fix tests from main merge * Remove Dev Warnings * Final test cleanups * Remove unused import --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kai Spencer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Phil Meier <[email protected]> Co-authored-by: Phil Meier <[email protected]>
Tomdango
added a commit
that referenced
this pull request
Apr 25, 2023
* Add dev warnings for v5 breaking changes (#150) * Add deprecation warning to footer columns prop * Shared warning object for v5 * Dev warning for DoDontList.tsx * Dev warning for TransactionalServiceName.tsx * Dev warning for ReviewDate.tsx * Lint --------- Co-authored-by: Thomas Judd-Cooper <[email protected]> * Fix Readme CI Build status tag (#149) Co-authored-by: Thomas Judd-Cooper <[email protected]> * Only run CI on main and PR's (#148) Currently ci build will run on any push and any pull_request. Pushing to a feature branch kicks off CI unintentionally. Co-authored-by: Thomas Judd-Cooper <[email protected]> * Bump ansi-regex from 4.1.0 to 4.1.1 (#156) Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Judd-Cooper <[email protected]> * Bump minimatch from 3.0.4 to 3.1.2 (#155) Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Judd-Cooper <[email protected]> * Update ErrorSummary component to forward refs (#135) This allows for things like programmatic keyboard focus in order to fulfil accessibility requirements. Co-authored-by: Phil Meier <[email protected]> Co-authored-by: Thomas Judd-Cooper <[email protected]> * bug/Checkbox declaration file inconsistency (#133) * Add "strictNullChecks", fix two cases where typing needs updating in line with checks. * Revert to .defaultProps * Throw error on default HeadingLevel.tsx case * Warn on invalid prop, test to cover * Better dev warning for heading level --------- Co-authored-by: Thomas Judd-Cooper <[email protected]> * Add aria-controls * Fix tests from main merge * Remove Dev Warnings * Final test cleanups * Remove unused import --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kai Spencer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Phil Meier <[email protected]> Co-authored-by: Phil Meier <[email protected]>
Tomdango
added a commit
that referenced
this pull request
Dec 4, 2023
* remove png from NHS Logo (#141) Co-authored-by: hrom1 <[email protected]> Co-authored-by: Thomas Judd-Cooper <[email protected]> * Remove footer three column variant (#151) * Remove footer three column prop and test * Remove story with columns * Update branch with latest changes * Remove TransactionalServiceName long variant (#152) * Remove TransactionalServiceName.tsx long variant * Update branch with latest changes * [nhsuk-frontend-v5] Move review date component into pattern (#138) * Move ReviewDate into patterns directory * Provide custom ordering to stories * Revert change to ReviewDate.test.tsx import * Adds migration docs for v3 * Update branch with latest changes from target * Callout for v3 as wip release * Add SVG Icon Attributes (#163) * Add SVG Icon fixes from NHSUK Frontend * Update snapshots * Add `do not` prefix to DoDontList (#153) * DoDontList don't item includes text `do not`, tests to cover * add prefixText prop and tests for DoDontList * Better documentation for DoDontList * Header Menu aria-expanded fix (#164) * Add dev warnings for v5 breaking changes (#150) * Add deprecation warning to footer columns prop * Shared warning object for v5 * Dev warning for DoDontList.tsx * Dev warning for TransactionalServiceName.tsx * Dev warning for ReviewDate.tsx * Lint --------- Co-authored-by: Thomas Judd-Cooper <[email protected]> * Fix Readme CI Build status tag (#149) Co-authored-by: Thomas Judd-Cooper <[email protected]> * Only run CI on main and PR's (#148) Currently ci build will run on any push and any pull_request. Pushing to a feature branch kicks off CI unintentionally. Co-authored-by: Thomas Judd-Cooper <[email protected]> * Bump ansi-regex from 4.1.0 to 4.1.1 (#156) Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Judd-Cooper <[email protected]> * Bump minimatch from 3.0.4 to 3.1.2 (#155) Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Judd-Cooper <[email protected]> * Update ErrorSummary component to forward refs (#135) This allows for things like programmatic keyboard focus in order to fulfil accessibility requirements. Co-authored-by: Phil Meier <[email protected]> Co-authored-by: Thomas Judd-Cooper <[email protected]> * bug/Checkbox declaration file inconsistency (#133) * Add "strictNullChecks", fix two cases where typing needs updating in line with checks. * Revert to .defaultProps * Throw error on default HeadingLevel.tsx case * Warn on invalid prop, test to cover * Better dev warning for heading level --------- Co-authored-by: Thomas Judd-Cooper <[email protected]> * Add aria-controls * Fix tests from main merge * Remove Dev Warnings * Final test cleanups * Remove unused import --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kai Spencer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Phil Meier <[email protected]> Co-authored-by: Phil Meier <[email protected]> * Add dev warnings for v5 breaking changes (#150) * Add deprecation warning to footer columns prop * Shared warning object for v5 * Dev warning for DoDontList.tsx * Dev warning for TransactionalServiceName.tsx * Dev warning for ReviewDate.tsx * Lint --------- Co-authored-by: Thomas Judd-Cooper <[email protected]> * Header Menu aria-expanded fix (#164) * Add dev warnings for v5 breaking changes (#150) * Add deprecation warning to footer columns prop * Shared warning object for v5 * Dev warning for DoDontList.tsx * Dev warning for TransactionalServiceName.tsx * Dev warning for ReviewDate.tsx * Lint --------- Co-authored-by: Thomas Judd-Cooper <[email protected]> * Fix Readme CI Build status tag (#149) Co-authored-by: Thomas Judd-Cooper <[email protected]> * Only run CI on main and PR's (#148) Currently ci build will run on any push and any pull_request. Pushing to a feature branch kicks off CI unintentionally. Co-authored-by: Thomas Judd-Cooper <[email protected]> * Bump ansi-regex from 4.1.0 to 4.1.1 (#156) Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Judd-Cooper <[email protected]> * Bump minimatch from 3.0.4 to 3.1.2 (#155) Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Judd-Cooper <[email protected]> * Update ErrorSummary component to forward refs (#135) This allows for things like programmatic keyboard focus in order to fulfil accessibility requirements. Co-authored-by: Phil Meier <[email protected]> Co-authored-by: Thomas Judd-Cooper <[email protected]> * bug/Checkbox declaration file inconsistency (#133) * Add "strictNullChecks", fix two cases where typing needs updating in line with checks. * Revert to .defaultProps * Throw error on default HeadingLevel.tsx case * Warn on invalid prop, test to cover * Better dev warning for heading level --------- Co-authored-by: Thomas Judd-Cooper <[email protected]> * Add aria-controls * Fix tests from main merge * Remove Dev Warnings * Final test cleanups * Remove unused import --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kai Spencer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Phil Meier <[email protected]> Co-authored-by: Phil Meier <[email protected]> * Add additional changelog * Bump version * Remove Dev Warning Tests * Fix linting issues * Fix circular dependency --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: VladJav <[email protected]> Co-authored-by: hrom1 <[email protected]> Co-authored-by: Kai Spencer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Phil Meier <[email protected]> Co-authored-by: Phil Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for things like programmatic keyboard focus in order to fulfil accessibility requirements.
Ref #69
(N.b. This might require more substantial version bump per https://reactjs.org/docs/forwarding-refs.html#note-for-component-library-maintainers)