Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: align all examples in the storybook with the NHS design system #216

Open
edwardhorsford opened this issue May 3, 2024 · 1 comment

Comments

@edwardhorsford
Copy link
Contributor

We should aim to align the examples in the storybook with the NHS design system.

Every examples in the NHS design system should be included in the storybook - ideally linking back to the design system. Ideally these would also show identical output markup.

If there are extra features to show, those could be included in addition - though things like #215 should be removed.

@edwardhorsford
Copy link
Contributor Author

Should also consider removing all examples of disabled components except where the design system shows them. These should not normally be used and by including them we risk encouraging teams to use them.

If they are absolutely necessary they should have a warning displayed near to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant