Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checking for IP address or domain name #38

Open
widhalmt opened this issue Sep 27, 2022 · 2 comments
Open

Improve checking for IP address or domain name #38

widhalmt opened this issue Sep 27, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@widhalmt
Copy link
Member

Thanks @RincewindsHat for pointing that out. There are valid domain names that start with a digit. To be honest, I don't know if a hostname may start with a digit, too according to RFC. But since it's possible, we have a domain name in server.address and client.address we should make sure to have a more robust check in filter-70-client.conf and filter-70-server.conf.

To be honest, I consider host- and domainnames starting with a digit as fairly exotic. So I think it's important to fix that but not an immediate must to start a fix right now.

@widhalmt widhalmt added the bug Something isn't working label Sep 27, 2022
@RincewindsHat
Copy link
Member

Also, it gets worse. I am not quite sure if those fields can contain an IPv6 address, but of course they could start with [a-f]

@widhalmt
Copy link
Member Author

I guess we are not the first to stumble on this. I hope, we'll find some ready to use code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants